Bitbucket vs Sitespeed.io

Do you review your Pull/Merge Request before assigning Reviewers?

If you work in a team opening a Pull Request (or Merge Request) looks appropriate. However, have you ever thought about opening a Pull/Merge Request when working by yourself? Here's a checklist of things you can review in your own:

• Pick the correct target branch
• Make Drafts explicit
• Name things properly
• Ask help for tools
• Remove the noise
• Fetch necessary data
• Understand Mergeability
• Pass the message
• Add screenshots
• Be found in the future
• Comment inline in your changes

Read the blog post for more detailed explanation for each item :D

What else do you review before asking for code review?

One of the magic tricks git performs is the ability to rewrite log history. You can do it in many ways, but git rebase -i is the one I most use. With this command, It’s possible to switch commits order, remove a commit, squash two or more commits, or edit, for instance.

It’s particularly useful to run it before opening a pull request. It allows developers to “clean up” the mess and organize commits before submitting to review. If you follow the practice 3 and 4, then the list of commits should look very similar to a task list. It should reveal the rationale you had, telling the story of how you end up with that final code.